Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix dependabot alerts #459

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rchincha
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha rchincha force-pushed the fix-deps branch 3 times, most recently from f0f09e6 to 8f97c80 Compare December 3, 2024 13:43
@rchincha
Copy link
Contributor Author

rchincha commented Dec 3, 2024

@raulkele if you are still up for it, can u pls see if you can move this along? think I am close.

@rchincha rchincha requested a review from raulkele December 4, 2024 13:54
@rchincha rchincha force-pushed the fix-deps branch 6 times, most recently from 67deb75 to fa2432e Compare December 8, 2024 07:13
@rchincha rchincha requested a review from andaaron December 8, 2024 07:32
@rchincha
Copy link
Contributor Author

rchincha commented Dec 8, 2024

@raulkele can u give some feedback on the ci failure?

rchincha added a commit to rchincha/zot that referenced this pull request Dec 9, 2024
project-zot/zui#459
^ updates react version to 18.x and other related changes.

Signed-off-by: Ramkumar Chinchani <[email protected]>
rchincha added a commit to rchincha/zot that referenced this pull request Dec 9, 2024
project-zot/zui#459
^ updates react version to 18.x and other related changes.

Signed-off-by: Ramkumar Chinchani <[email protected]>
@rchincha
Copy link
Contributor Author

@andaaron tested this with zot build, and works fine. We just need to fix the unit tests.
Let's first bump up react-dom (this PR) to 18.x and then let's look at 19.x
We use quite a few libs and they need to catch up too.

Signed-off-by: Ramkumar Chinchani <[email protected]>
@raulkele
Copy link
Collaborator

Im in the process of checking the issues

@raulkele
Copy link
Collaborator

I believe I've found the issue, been fiddling around with it for a while. #367 is finally starting to bite us. It's getting more and more difficult to upgrade our dependencies while using the outdated toolchain. I'll see if I can get these to pass while I investigate a bit about the toolchain upgrade during Christmas vacation

@rchincha
Copy link
Contributor Author

rchincha commented Dec 18, 2024

I believe I've found the issue, been fiddling around with it for a while. #367 is finally starting to bite us. It's getting more and more difficult to upgrade our dependencies while using the outdated toolchain. I'll see if I can get these to pass while I investigate a bit about the toolchain upgrade during Christmas vacation

I tested zot itself against this change. UI renders fine and nothing obvious seems broken.

Was trying to fix the following, without success :(

console.error
      Warning: An update to ForwardRef(TouchRipple) inside a test was not wrapped in act(...).
      
      When testing, code that causes React state updates should be wrapped into act(...):

@raulkele
Copy link
Collaborator

I believe I've found the issue, been fiddling around with it for a while. #367 is finally starting to bite us. It's getting more and more difficult to upgrade our dependencies while using the outdated toolchain. I'll see if I can get these to pass while I investigate a bit about the toolchain upgrade during Christmas vacation

I tested zot itself against this change. UI renders fine and nothing obvious seems broken.

Was trying to fix the following, without success :(

console.error
      Warning: An update to ForwardRef(TouchRipple) inside a test was not wrapped in act(...).
      
      When testing, code that causes React state updates should be wrapped into act(...):

Yup, the mismatch between newer dependencies and old toolchain is causing tests to mees up. I tested the ui myself and found no issue. It's up to you if you wanna give me a couple of days to make it pass the checks or if we need to merge it as is

@rchincha
Copy link
Contributor Author

It's up to you if you wanna give me a couple of days to make it pass the checks or if we need to merge it as is

I can wait :) and help appreciated.

@rchincha
Copy link
Contributor Author

https://www.npmjs.com/package/react-dom
^ not sure if rest of the ecosystem is ready for 19.x just yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants