-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix dependabot alerts #459
base: main
Are you sure you want to change the base?
Conversation
f0f09e6
to
8f97c80
Compare
@raulkele if you are still up for it, can u pls see if you can move this along? think I am close. |
67deb75
to
fa2432e
Compare
@raulkele can u give some feedback on the ci failure? |
project-zot/zui#459 ^ updates react version to 18.x and other related changes. Signed-off-by: Ramkumar Chinchani <[email protected]>
project-zot/zui#459 ^ updates react version to 18.x and other related changes. Signed-off-by: Ramkumar Chinchani <[email protected]>
@andaaron tested this with zot build, and works fine. We just need to fix the unit tests. |
Signed-off-by: Ramkumar Chinchani <[email protected]>
Im in the process of checking the issues |
I believe I've found the issue, been fiddling around with it for a while. #367 is finally starting to bite us. It's getting more and more difficult to upgrade our dependencies while using the outdated toolchain. I'll see if I can get these to pass while I investigate a bit about the toolchain upgrade during Christmas vacation |
I tested zot itself against this change. UI renders fine and nothing obvious seems broken. Was trying to fix the following, without success :(
|
Yup, the mismatch between newer dependencies and old toolchain is causing tests to mees up. I tested the ui myself and found no issue. It's up to you if you wanna give me a couple of days to make it pass the checks or if we need to merge it as is |
I can wait :) and help appreciated. |
https://www.npmjs.com/package/react-dom |
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.